Add Python script for generating resource entries #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@allejo hmm good point, we probably don't want to be downloading files from anywhere 😬 I don't think this new process is meant to fully replace the current workflow, just shortcut it a bunch and provide some early feedback for requestors (e.g. the preview link). Given that, maybe we just use the asset link as provided in the issue, as a first pass. An engineer still needs to review (and possibly update) the PR anyway. We can try this out a few times and see how we like it or what changes to make. Can always come back to update this process further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I've only committed the Python script portion of this PR, I'll mark this as a draft for now. As I was planning this out and writing it, I ran into some things I wanted to get more opinions on.
Should we download assets?
Downloading assets will fail if said files are not public. Some ideas on how to handle this situation:
Security Concerns
Automatically downloading files from the internet is a very secure thing to do. How should we handle the situation?
/cc @machikoyasuda @thekaveman
Closes #435